Skip to content

Update GCC builtin declarations #5918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 5, 2021

Conversation

tautschnig
Copy link
Collaborator

These builtins match GCC revision 425afe1f0c907.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #5918 (249bee1) into develop (320a9f8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5918   +/-   ##
========================================
  Coverage    76.08%   76.09%           
========================================
  Files         1548     1548           
  Lines       166399   166401    +2     
========================================
+ Hits        126603   126619   +16     
+ Misses       39796    39782   -14     
Impacted Files Coverage Δ
src/ansi-c/ansi_c_internal_additions.cpp 90.36% <ø> (ø)
src/crangler/scanner.l 63.63% <ø> (ø)
src/ansi-c/builtin_factory.cpp 66.66% <100.00%> (+0.70%) ⬆️
src/ansi-c/expr2c.cpp 66.10% <0.00%> (+0.52%) ⬆️
src/ansi-c/c_typecast.cpp 80.38% <0.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4f9c45...249bee1. Read the comment docs.

@tautschnig tautschnig force-pushed the update-gcc-builtins branch from 2a62346 to d800816 Compare March 15, 2021 12:28
@tautschnig tautschnig force-pushed the update-gcc-builtins branch from d800816 to 992e588 Compare March 15, 2021 12:46
@tautschnig tautschnig force-pushed the update-gcc-builtins branch 3 times, most recently from ed7fb2a to 489664d Compare March 16, 2021 23:21
@tautschnig tautschnig force-pushed the update-gcc-builtins branch from 489664d to 4788442 Compare March 31, 2021 15:46
@tautschnig tautschnig requested a review from a team as a code owner March 31, 2021 15:46
@tautschnig tautschnig force-pushed the update-gcc-builtins branch from 4788442 to fa4be9d Compare March 31, 2021 19:31
GCC has moved from Subversion to Git, and the files providing
definitions of built-ins have changed.
We want each declaration to be on a single line to simplify automatic
manipulation, e.g., using get-gcc-builtins.sh.
These builtins match GCC revision 425afe1f0c907.
Although https://gcc.gnu.org/onlinedocs/gcc/x86-Built-in-Functions.html
claims the types are di (long long), the actual uses im mmintrin.h are
1-element vectors in GCC, and Clang's BuiltinsX86.def confirms this.

Fixes: diffblue#6470
@kroening kroening merged commit 48bfd20 into diffblue:develop Dec 5, 2021
@tautschnig tautschnig deleted the update-gcc-builtins branch December 5, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants